Dynamic Plugin Nodebrowser

woei · October 16, 2018, 12:49pm

new(ly) cloned dynamic plugins don’t show up in the alphabetical list in the nodebrowser. can only find them via category.

reproduce: new v4 patch, clone template, search for it in the nodebrowser

joreg · September 27, 2019, 3:41pm

sorry for late. i’ve just tried to replicate this in b38.1 to no avail:

open b38.1
save patch
dblclick for nodebrowser -> clone c# template with name “foo”
dblclick for nodebrowser again -> type “foo” -> node shows up as expected

can you confirm this works now or are you doing something differently?

woei · October 1, 2019, 5:03pm

skip the part, where you save the empty patch.

just figured it’s not only dynamic plugins but also vl, modules, etc. doesn’t have to be newly created. drag n dropping some existing ‘externals’ on the unsaved patch behaves the same.
everything can be found in the category list.

woei · October 1, 2019, 5:43pm

seems like only tag view is factoring in the search paths when determining the visible node entries:

github.com

vvvv/vvvv-sdk/blob/73ce4a54259e701da37334dfa29190852486c142/vvvv45/src/nodes/plugins/vvvv/NodeBrowser/TagPanel.cs#L504


                                           return false;

                                   });

    }

}



private bool IsAvailableInActivePatch(INodeInfo nodeInfo)

{

    return IsAvailableInActivePatch(nodeInfo, true);

}



private bool IsAvailableInActivePatch(INodeInfo nodeInfo, bool lookInSearchPaths)

{

    string filename = nodeInfo.Filename;

    if (string.IsNullOrEmpty(filename))

        return true;

    

    string dir = Path.GetDirectoryName(filename);

    if (string.IsNullOrEmpty(dir))

        return true;

    

    // Hack to make it work again 50

actually this even happens, if the patch is saved, as soon as the external file not located in a subdirectory of the directory, where the patch is saved:

github.com

vvvv/vvvv-sdk/blob/73ce4a54259e701da37334dfa29190852486c142/vvvv45/src/nodes/plugins/vvvv/NodeBrowser/TagPanel.cs#L521


if (string.IsNullOrEmpty(dir))

    return true;



// Hack to make it work again 50

var nodeCollection = NodeBrowser.FNodeCollection;

if (nodeCollection == null)

    return true;



if (nodeInfo != FCurrentPatchWindowNodeInfo)

{

    if (!string.IsNullOrEmpty(FCurrentDir))

        //available if local

        if (dir.StartsWith(FCurrentDir))

            return true;

    

    if (lookInSearchPaths && nodeInfo.Type != NodeType.Patch)

    {

        //available if from any of the global paths

        return nodeCollection.IsInUserDefinedSearchPath(nodeInfo.Factory, dir);

    }

}

joreg · October 7, 2019, 5:49pm

ok, i can see now. i’m afraid though, we considered this lower priority.

specifically since with the upcoming b39 at least when cloning a template, they will now show up in the nodebrowser. you don’t even have to save the patch anymore before, because they now have a default save location.

so the problem is now reduced to externals you drag-drop into the patch from sources that are not yet known as searchpaths.

woei · October 10, 2019, 8:56pm

what’s the reason for hiding away nodes anyways?

the problem also occurs if you are working in a subpatch (saved somewhere else than the parent) clone a dynamic plugin in the subpatch, which will be created automatically in subpatchfolder/plugin and therefore not in the global searchpath, not visible to the parent patch (or any other patch)

system · September 29, 2021, 10:30pm

This topic was automatically closed 365 days after the last reply. New replies are no longer allowed.